Keep the admin surface local while serving tiles on the LAN

Binding to 0.0.0.0 used to demand credentials because the admin console and the tile routes shared one listener. That forced a choice between keeping the console off the network and letting other machines fetch tiles. Admin routes are now loopback-only by default: the service can bind 0.0.0.0 so /tiles, /vectors, the catalog and the probes reach the LAN, while /admin and /api/v1/admin answer 403 to anything arriving from another host. Credentials are only required when ADMIN_ALLOW_REMOTE=true actually opens the console up, which is the case worth guarding. Tests cover both sides: a remote admin request is refused, a remote tile request still reaches the token check.
2026-10-16 10:41:32 +08:00
parent 93bfd406ba
commit 46d83145d9
7 changed files with 145 additions and 18 deletions
@@ -277,3 +277,55 @@ func TestScanErrorStatusMapping(t *testing.T) {
 		}
 	}
 }
+
+func TestAdminIsLoopbackOnlyByDefault(t *testing.T) {
+	store := newTestStore(t, t.TempDir())
+	server, err := New(store, basemap.SystemInfo{ServiceName: "basemap-pusher"}, Options{})
+	if err != nil {
+		t.Fatalf("new server: %v", err)
+	}
+	handler := server.Handler()
+
+	call := func(path, remote string) int {
+		request := httptest.NewRequest(http.MethodGet, path, nil)
+		request.RemoteAddr = remote
+		recorder := httptest.NewRecorder()
+		handler.ServeHTTP(recorder, request)
+		return recorder.Code
+	}
+
+	if got := call("/api/v1/admin/basemaps", "127.0.0.1:5555"); got != http.StatusOK {
+		t.Fatalf("expected local admin access, got %d", got)
+	}
+	if got := call("/api/v1/admin/basemaps", "192.168.1.50:5555"); got != http.StatusForbidden {
+		t.Fatalf("expected a remote admin request to be refused, got %d", got)
+	}
+
+	// The point of the split: tile traffic still reaches the service from the
+	// LAN, it just has to carry a valid token.
+	if got := call("/tiles/demo/current/0/0/0.png", "192.168.1.50:5555"); got != http.StatusUnauthorized {
+		t.Fatalf("expected the tile route to stay reachable from the LAN (401), got %d", got)
+	}
+	if got := call("/health", "192.168.1.50:5555"); got != http.StatusOK {
+		t.Fatalf("expected health to stay reachable, got %d", got)
+	}
+}
+
+func TestAdminAllowRemoteOptIn(t *testing.T) {
+	store := newTestStore(t, t.TempDir())
+	server, err := New(store, basemap.SystemInfo{ServiceName: "basemap-pusher"}, Options{
+		Admin: AdminAuth{AllowRemote: true},
+	})
+	if err != nil {
+		t.Fatalf("new server: %v", err)
+	}
+
+	request := httptest.NewRequest(http.MethodGet, "/api/v1/admin/basemaps", nil)
+	request.RemoteAddr = "192.168.1.50:5555"
+	recorder := httptest.NewRecorder()
+	server.Handler().ServeHTTP(recorder, request)
+
+	if recorder.Code != http.StatusOK {
+		t.Fatalf("expected ADMIN_ALLOW_REMOTE to permit remote admin calls, got %d", recorder.Code)
+	}
+}